-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to htsjdk 2.19.0 #77
Upgrade to htsjdk 2.19.0 #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @tomwhite - we're overhauling refactoring all the cram code in htsjdk. Well try to audit the disq usages as we do this going forward so we can get out a little in front of these.
LGTM once htsjdk is released and tests pass.
Thanks @cmnbroad. It looks like htsjdk 2.18.2 does not have this change, so this PR is not needed (for now). |
I didn't include the most recent several commits in htsjdk 2.18.2 because they introduced new issues like this and I wanted to get something out soon before dealing with that. We'll have a 2.19.0 pretty soon which includes those changes. |
…ry that affects CramSource in Disq. See the note about incompatible CRAM changes at https://github.com/samtools/htsjdk/releases/tag/2.17.0. This commit uses the new CRAIEntry API introduced in samtools/htsjdk#1256
062017c
to
5a534e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
The changes to CRAM have introduced an incompatible change to CRAIEntry that affects CramSource in Disq. See the note about incompatible CRAM changes
at https://github.com/samtools/htsjdk/releases/tag/2.17.0.
This commit uses the new CRAIEntry API introduced in samtools/htsjdk#1256
Note: the change has not been released yet (so this PR will fail to compile), but a new htsjdk release is imminent, so the Disq 0.2.0 release should wait for it.